[PM-15402] Remove TaxInfoComponent from trial-initiation.module.ts
#12996
+20
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonashendrickx
requested review from
JimmyVo16 and
Patrick-Pimentel-Bitwarden
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12996 +/- ##
==========================================
+ Coverage 35.21% 35.28% +0.07%
==========================================
Files 3126 3124 -2
Lines 92542 92358 -184
Branches 16854 16794 -60
==========================================
+ Hits 32589 32590 +1
+ Misses 57496 57311 -185
Partials 2457 2457 ☔ View full report in Codecov by Sentry. |
JimmyVo16
previously approved these changes
Jan 21, 2025
cturnbull-bitwarden
previously approved these changes
Jan 22, 2025
Patrick-Pimentel-Bitwarden
previously approved these changes
Jan 22, 2025
# Conflicts: # apps/web/src/app/billing/accounts/trial-initiation/trial-billing-step.component.html # apps/web/src/app/billing/accounts/trial-initiation/trial-billing-step.component.ts # apps/web/src/app/billing/trial-initiation/trial-initiation.module.ts
jonashendrickx
dismissed stale reviews from Patrick-Pimentel-Bitwarden, cturnbull-bitwarden, and JimmyVo16
via
1577541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15402
📔 Objective
TaxInfoComponentfrom the trial initiation procedure. This allows the old component to be dropped in a subsequent pull request.Tax IDfield to the trial initiation wizard as required for plans that are for business use.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes